Change in ovirt-engine[master]: core: stop upgrade when shell script fail

emesika at redhat.com emesika at redhat.com
Tue Jan 12 23:03:46 UTC 2016


Eli Mesika has submitted this change and it was merged.

Change subject: core: stop upgrade when shell script fail
......................................................................


core: stop upgrade when shell script fail

This patch fixes a bug that occurs when we have a shell upgrade script
that fails to execute.
Current behaviour is that the script fails and upgrade process continues
and even generates a SUCCESS result on CI tests.

This patch adds a missing check on the result of running the script and
terminates upgrade procedure if shell script fails with a proper
message.

Change-Id: Ic18a8a567945c4d3e709d28b85691f0e3b67e2e5
Signed-off-by: emesika <emesika at redhat.com>
---
M packaging/dbscripts/dbfunc-common.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Eli Mesika: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic18a8a567945c4d3e709d28b85691f0e3b67e2e5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list