Change in ovirt-engine[master]: core: CommandBase - fix getParentParameters()

[laravot at redhat.com]

Liron Aravot has submitted this change and it was merged.

Change subject: core: CommandBase - fix getParentParameters()
......................................................................


core: CommandBase - fix getParentParameters()

getParentParameters() is used to get the info for the command for which
the endAction() method should be executed when the created task ends.
When the parent command has a callback the parameters of the current command
should always be returned as the callback should be the one responsible
to call the endAction() when the child commands ends, otherwise the
AsyncTaskManager will execute it prematurely which is wrong.
This patch fixes this issue and adds some documentation to the method.

Change-Id: Ib49de599e4baf5f00b4e3117a4ef49cad6b91827
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/49378
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib49de599e4baf5f00b4e3117a4ef49cad6b91827
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>