Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: resetting spUUID to a random value only if really n...

sbonazzo at redhat.com sbonazzo at redhat.com
Tue Jan 19 07:37:46 UTC 2016


Sandro Bonazzola has submitted this change and it was merged.

Change subject: storage: resetting spUUID to a random value only if really needed
......................................................................


storage: resetting spUUID to a random value only if really needed

hosted-engine-setup generates answer file with a blank SP UUID
for additional hosts cause it correctly disconnected its SD
from the boostrap storage pool.
If we want to use the answerfile for not-interactively replaing
the scenario we need a valid spUUID value otherwise we are not
able to create the bootstrap storage pool.
On the other side, passing an answerfile via CLI is a valid
alternative instead of download it from another host via scp.
And in that case we should honour the BLANK UUID.
So resetting spUUID to blank only if really needed to create
a new boostrap storage pool.

Change-Id: I67569bc6902a176565269f2bcbec569b51549181
Bug-Url: https://bugzilla.redhat.com/1277010
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Martin Sivák: Looks good to me, but someone else must approve
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51867
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67569bc6902a176565269f2bcbec569b51549181
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list