Change in ovirt-engine[master]: core: dao tests should fail fast with clear error message

masayag at redhat.com masayag at redhat.com
Tue Jan 19 19:00:43 UTC 2016


Moti Asayag has submitted this change and it was merged.

Change subject: core: dao tests should fail fast with clear error message
......................................................................


core: dao tests should fail fast with clear error message

We need to stop tests asap if initialization failed. Doing so, we
get rid of big number of 'false failures' hiding true failure,
humongous log file, and save some cpu time (on
my pc tests fails for bad initialization in 1m36.919s instead of
former 3m41.748s).

Signed-off-by: Martin Mucha <mmucha at redhat.com>

Change-Id: I86783a6849577c3a24692a099d6d0440a706fb54
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java
1 file changed, 37 insertions(+), 8 deletions(-)

Approvals:
  Martin Mucha: Verified
  Moti Asayag: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86783a6849577c3a24692a099d6d0440a706fb54
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list