Change in ovirt-engine[master]: core: Prevent host device copy on pinned host mismatch

mperina at redhat.com mperina at redhat.com
Wed Jan 20 12:36:54 UTC 2016


Martin Peřina has submitted this change and it was merged.

Change subject: core: Prevent host device copy on pinned host mismatch
......................................................................


core: Prevent host device copy on pinned host mismatch

When user is creating a VM from pre-existing configuration
(Template/Snapshot/Import) and has the ability to override the "pinned-to-host"
value, it results in a VM being created with inconsistent host devices attached
(device name from old host, but with new host id).

Most cases were covered by VmDeviceUtils#copyVmDevices and import by
VmDeviceUtils#addImportedOtherDevices.

Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281428
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 47 insertions(+), 9 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Shmuel Leib Melamud: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/52374
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list