Change in ovirt-engine[master]: core: Remove duplicate code

tnisan at redhat.com tnisan at redhat.com
Wed Jan 20 15:52:37 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove duplicate code
......................................................................


core: Remove duplicate code

FenceAgent and VdsStatic contained the exact same pmOptionsStringToMap
method, this patch extracts it to a helper class and removed the dupicate
refernces

Change-Id: Ib2f948d674f1501a0ab7247373bf21cc3770b87e
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceAgent.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/pm/PowerManagementUtils.java
R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/pm/PowerManagementUtilsTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
6 files changed, 45 insertions(+), 70 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/52363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2f948d674f1501a0ab7247373bf21cc3770b87e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list