Change in ovirt-engine[master]: core: PairFirstComparator

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: PairFirstComparator
......................................................................


core: PairFirstComparator

Introducing a PairFirstComparator that compares the first element of a
Pair and replace all the inline implementations with it.

Change-Id: I577bb51b5be3e6dfa88854e924579a0f4e4eaa5c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NaturalOrderComparator.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairFirstComparator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/PairFirstComparatorTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoImpl.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/IconUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
8 files changed, 79 insertions(+), 33 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I577bb51b5be3e6dfa88854e924579a0f4e4eaa5c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>