Change in ovirt-hosted-engine-ha[master]: upgrade: adding a docstring for _is_conf_volume_there

msivak at redhat.com msivak at redhat.com
Thu Jan 21 12:53:51 UTC 2016


Martin Sivák has submitted this change and it was merged.

Change subject: upgrade: adding a docstring for _is_conf_volume_there
......................................................................


upgrade: adding a docstring for _is_conf_volume_there

The code to detect the configuration image is not trivial so
it's better to describe it.
Since nothing calls prepareImage on the configuration image before
we discover it, the volume shouldn't be available but it is so
it's better to keep track of this behavior.

Change-Id: I09cac64724fe77e51687ecaf558dc1eec47a5daa
Bug-Url: https://bugzilla.redhat.com/1297457
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Martin Sivák: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51724
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09cac64724fe77e51687ecaf558dc1eec47a5daa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list