Change in ovirt-engine[master]: Use the proper whitelist for MigrateVmCommand.canDoAction

dfediuck at redhat.com dfediuck at redhat.com
Wed Jan 27 12:08:40 UTC 2016


Doron Fediuck has submitted this change and it was merged.

Change subject: Use the proper whitelist for MigrateVmCommand.canDoAction
......................................................................


Use the proper whitelist for MigrateVmCommand.canDoAction

The execute methods gets whitelist using the getVdsWhiteList
method. But canDoAction used getParameters directly.

This caused trouble for MigrateVmToServerCommand which overrides
getVdsWhitelist as a different value was used for canDoAction
and execute calls.

Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258960
Signed-off-by: Martin Sivak <msivak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Sivák: Verified
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/52676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list