Change in ovirt-engine[master]: core: GlusterBrickValidatorTest assertions

amureini at redhat.com amureini at redhat.com
Tue Jul 5 08:59:24 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: GlusterBrickValidatorTest assertions
......................................................................


core: GlusterBrickValidatorTest assertions

Modernize the assertions in this test class using the assertThat syntax
with the custom matchers from
org.ovirt.engine.core.bll.validator.ValidationResultMatchers.
This lends towards making the code more readable and the failure
messages clearer.

Change-Id: I957166c0514ad1a33d804fd69259c2e22c4277e7
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java
1 file changed, 27 insertions(+), 30 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/60174
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I957166c0514ad1a33d804fd69259c2e22c4277e7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list