Change in ovirt-engine[master]: core: Unify similar methods in VdsBrokerObjectsBuilder

tnisan at redhat.com tnisan at redhat.com
Sun Jul 10 13:15:30 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Unify similar methods in VdsBrokerObjectsBuilder
......................................................................


core: Unify similar methods in VdsBrokerObjectsBuilder

The methods extractIntegerList and extracStringtList (sic) are doing
exactly the same aside for the fact that one returns null when elements
are not found and the second returns an empty list.
Both methods were unified to a single method

Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 11 insertions(+), 27 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Looks good to me, approved
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/58928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list