Change in ovirt-engine[master]: core: Fix validation in PauseVmCommand
tnisan at redhat.com
tnisan at redhat.com
Wed Jul 13 11:08:04 UTC 2016
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix validation in PauseVmCommand
......................................................................
core: Fix validation in PauseVmCommand
The validation in PauseVmCommand passed the messages as a parameter to
canPauseVm and added the validation error messages if needed to it, since
the canPauseVm method is ran from within the command it can:
1. Become private
2. Add the messages directly as per the Engine common practices
Related-To: https://bugzilla.redhat.com/854932
Change-Id: Icb5a8fda42fa95fdac0e20fb157859f955c3adec
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java
1 file changed, 7 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59791
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb5a8fda42fa95fdac0e20fb157859f955c3adec
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list