Change in ovirt-engine[master]: backend: Remove code duplication in v2v providers

[mbetak at redhat.com]

Martin Betak has submitted this change and it was merged.

Change subject: backend: Remove code duplication in v2v providers
......................................................................


backend: Remove code duplication in v2v providers

The KVM, Vmware and XEN ProviderProxies contained significtant portion of
duplicate that was extracted into new AbstractVmProviderProxy base class.

For this purpose also their respective parameter classes now extend
VmProviderProperties class containing shared fields on which
AbstractVmProviderProxy depends.

Change-Id: I4f9acf44ef27e7fbbd1580e0d4542b83f2016a4a
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/AbstractVmProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/KVMVmProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/VmwareVmProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/XENVmProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/KVMVmProviderProperties.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmProviderProperties.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmwareVmProviderProperties.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/XENVmProviderProperties.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
10 files changed, 136 insertions(+), 248 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/60740
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f9acf44ef27e7fbbd1580e0d4542b83f2016a4a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>