Change in ovirt-engine[master]: core: StorageDomainNumberOfVmDisksComparator domain list

amureini at redhat.com amureini at redhat.com
Wed Jul 20 13:45:58 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageDomainNumberOfVmDisksComparator domain list
......................................................................


core: StorageDomainNumberOfVmDisksComparator domain list

Remove the domain list parameter from
StorageDomainNumberOfVmDisksComparator. The list of domains can be
inferred from the collection of disks, and any domains missing from that
list can assumed to have 0 relevant disks on them by using
getOrDefault(key, 0).

Change-Id: I24af6711c92f05215846364e85151717aed4a668
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageDomainNumberOfVmDisksComparator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageDomainNumberOfVmDisksComparatorTest.java
4 files changed, 12 insertions(+), 26 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60654
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24af6711c92f05215846364e85151717aed4a668
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list