Change in ovirt-engine[master]: core: rm DoesImageExistVDSCommand

laravot at redhat.com laravot at redhat.com
Tue Jul 26 09:33:33 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: rm DoesImageExistVDSCommand
......................................................................


core: rm DoesImageExistVDSCommand

DoesImageExistVDSCommand is a subclass of GetImageInfoVDSCommand
and is used to determine if the image exists.
The difference between this command and GetImageInfo is that GetImageInfo
parses to return value into a object.
As this command is executed as part of the validation when doing import,
we can simply use GetImageInfo and delete DoesImageExistVDSCommand.

Change-Id: I9b431ee842cf87b8b6378ef2641d64d2fa68df42
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DoesImageExistVDSCommand.java
3 files changed, 2 insertions(+), 43 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/60956
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b431ee842cf87b8b6378ef2641d64d2fa68df42
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list