Change in ovirt-engine[master]: webadmin: Hide hosted engine tab when editing host

derez at redhat.com derez at redhat.com
Tue Jul 26 15:05:42 UTC 2016


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: Hide hosted engine tab when editing host
......................................................................


webadmin: Hide hosted engine tab when editing host

The hosted engine tab in host editing or adding dialog
in the ui is only relevant when adding a new host.
This patch hides the tab when a host is edited.

To achieve this the initialization of the popup window
was moved after the host model initialization.
This allows setting the visibility for hostedEngineTab in
HostPopupView by using the getIsNew method (was already
implemented but didn't work since the relevant fields
weren't initialized).

Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9
Bug-Url: https://bugzilla.redhat.com/1350423
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Jenny Tokar: Verified



-- 
To view, visit https://gerrit.ovirt.org/61093
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list