Change in ovirt-engine[master]: core: Validate affinity label name length

rgolan at redhat.com rgolan at redhat.com
Thu Jul 28 09:42:19 UTC 2016


Roy Golan has submitted this change and it was merged.

Change subject: core: Validate affinity label name length
......................................................................


core: Validate affinity label name length

Added validation for affinity label name length before it fails on
postgres.

Added all violations attributes to the messages returned from
ValidationUtils, that way all the attributes are exposed and can be used
in error messages.

Change-Id: I8f0cc33a60d5b0e8035d4ec793f4161c96fade96
Bug-Url: https://bugzilla.redhat.com/1350230
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
---
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LabelActionParametersTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LabelActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Label.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 85 insertions(+), 2 deletions(-)

Approvals:
  Roman Mohr: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Jenny Tokar: Verified



-- 
To view, visit https://gerrit.ovirt.org/60477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f0cc33a60d5b0e8035d4ec793f4161c96fade96
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list