Change in ovirt-engine[master]: core: ImportVmCommandTest mocking type strictness
amureini at redhat.com
amureini at redhat.com
Thu Jul 28 16:30:29 UTC 2016
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ImportVmCommandTest mocking type strictness
......................................................................
core: ImportVmCommandTest mocking type strictness
Made the mocking a tad stricter by using type-safe matchers such as
anyListOf(Class) instead of raw matches such as anyList().
This change makes the test code a bit easier to read, and helps avoid
stupid mistakes in the test.
Change-Id: Ia5d1340196e04da0a38de15f97166cdefd82a697
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
1 file changed, 14 insertions(+), 14 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61590
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5d1340196e04da0a38de15f97166cdefd82a697
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list