Change in ovirt-engine[master]: core: fixes related to validating nics mac addresses

[alkaplan at redhat.com]

Alona Kaplan has submitted this change and it was merged.

Change subject: core: fixes related to validating nics mac addresses
......................................................................


core: fixes related to validating nics mac addresses

Code in two touched duplicate methods is about to change in following
patch. Knowing that I extracted this duplicity.

• duplicity removed
• method removed from ImportValidator where it does not belong
• removed unneccesary 'upcast'

Change-Id: If85a8b5b4f462a83aa70701090d57958beee3326
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java
5 files changed, 69 insertions(+), 43 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If85a8b5b4f462a83aa70701090d57958beee3326
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>