Change in ovirt-engine[master]: core: cleanup in vm fetchers

[ahadas at redhat.com]

Arik Hadas has submitted this change and it was merged.

Change subject: core: cleanup in vm fetchers
......................................................................


core: cleanup in vm fetchers

VmsStatisticsFetcher only needs to override the poll request from VDSM
(GetAllVmStats instead of List) - it doesn't need to override the long
VmsListFetcher#fetch for that.

In this patch only the relevant part from 'fetch' method that needs to
be overridden is extracted to separate method. This change reduce code
duplication.

In addition, add SupressWarning on intentional unchecked cast and
rename a variable for better readability.

Change-Id: I3eeb9ebaa04e5c52de8cc6b03162054239d5ddc6
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java
2 files changed, 14 insertions(+), 23 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/58410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3eeb9ebaa04e5c52de8cc6b03162054239d5ddc6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>