Change in ovirt-engine[master]: core: move guest memory related fields to statistics

ahadas at redhat.com ahadas at redhat.com
Thu Jun 2 13:47:16 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: move guest memory related fields to statistics
......................................................................


core: move guest memory related fields to statistics

The information related to the memory within the guest used to be
stored in VmDynamic. This is wrong. First, conceptually it is more
'statistics' then 'runtime' info. Second, it is updated frequenty
and therefore leads to many updates of VM dynamic data by the VMs
monitoring.

This patch moves these fields to VmStatistics instead.

Change-Id: If9944576a3283d77ad6c46c14f366efdf536b816
Bug-Url: https://bugzilla.redhat.com/1340722
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M packaging/dbscripts/create_dwh_views.sql
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_00_0760_move_guest_mem_fields_to_statistics.sql
M packaging/dbscripts/vms_sp.sql
10 files changed, 117 insertions(+), 91 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, but someone else must approve
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/58305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9944576a3283d77ad6c46c14f366efdf536b816
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list