Change in ovirt-guest-agent[master]: hooks: Make execution more robust

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Jun 8 07:25:17 UTC 2016


Vinzenz Feenstra has submitted this change and it was merged.

Change subject: hooks: Make execution more robust
......................................................................


hooks: Make execution more robust

Previously, exceptions raised due to executing potentially not
executable or inaccessible hooks caused exceptions to be passed
through to the VirtIO read loop. Which caused that any other hook
configured after that not being executed.

This patch handles the OSErrors potentially raised by the subprocess
usage

Change-Id: I951f6e6ecabdebb9abeba7449329a363296411f7
Bug-Url: https://bugzilla.redhat.com/1343017
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M ovirt-guest-agent/hooks.py
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Vinzenz Feenstra: Verified; Looks good to me, approved
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/58720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I951f6e6ecabdebb9abeba7449329a363296411f7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list