Change in ovirt-engine[master]: core: HE - uploadImageToStream task is never cleared

tnisan at redhat.com tnisan at redhat.com
Tue Jun 14 08:09:58 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: HE - uploadImageToStream task is never cleared
......................................................................


core: HE - uploadImageToStream task is never cleared

When downloading the data from the HE configuration disk the created task
isn't polled which means it'll remain forever.
When attempting to stop the spm its first checked whether there are pending
tasks. as the task will remain forever it won't be possible to stop the spm.

This patch changes the code to use the bll command instead of the vds command,
which will take care of polling and clearing the task.

Change-Id: I978be73b8df88a59bd30a0f114285d5999e353f7
Bug-Url: https://bugzilla.redhat.com/1343618
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcher.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcherTest.java
2 files changed, 54 insertions(+), 20 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/58807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I978be73b8df88a59bd30a0f114285d5999e353f7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list