Change in ovirt-engine[master]: core: Use ReplacementUtils

masayag at redhat.com masayag at redhat.com
Thu Jun 16 18:48:44 UTC 2016


Moti Asayag has submitted this change and it was merged.

Change subject: core: Use ReplacementUtils
......................................................................


core: Use ReplacementUtils

• used ReplacementUtils in CommandBase instead of constructing set
string manually

• replaced usage of MessageFormat in ReplacementUtils with
String.format; MessageFormat is intended for internationalization, not
simple string formatting.

Change-Id: I123801a63bfffd3519fbacc7f9ca15e14f73f878
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/59332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I123801a63bfffd3519fbacc7f9ca15e14f73f878
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list