Change in ovirt-engine[master]: core: Let entity builders return a fresh loaded entity from ...

mperina at redhat.com mperina at redhat.com
Tue Jun 21 11:54:34 UTC 2016


Martin Peřina has submitted this change and it was merged.

Change subject: core: Let entity builders return a fresh loaded entity from the database
......................................................................


core: Let entity builders return a fresh loaded entity from the database

Instead of returning the builder template on a #persist() call make sure
that a new entity - fresh from the database - is returned. This makes
the returned instance much more useful for tests.

Change-Id: I48d6290d886f23b62b0a50e38b10d10526f179b5
Signed-off-by: Roman Mohr <rmohr at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/ClusterBuilder.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/MacPoolBuilder.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/VdsBuilder.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/builder/VmBuilder.java
4 files changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Martin Peřina: Looks good to me, but someone else must approve
  Roman Mohr: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/59300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48d6290d886f23b62b0a50e38b10d10526f179b5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list