Change in otopi[master]: machine_dialog: fix the comparison for default

didi at redhat.com didi at redhat.com
Tue Jun 21 14:14:32 UTC 2016


Yedidyah Bar David has submitted this change and it was merged.

Change subject: machine_dialog: fix the comparison for default
......................................................................


machine_dialog: fix the comparison for default

Currently, it evaluates to False even if no values is set.

Set "default" to None so the comparison works properly.

Change-Id: Ia235e2e886b72cff056b6221923f0eb50178fedd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346860
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/plugins/otopi/dialog/machine.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests
  Ryan Barry: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59245
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia235e2e886b72cff056b6221923f0eb50178fedd
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list