Change in ovirt-engine[master]: webadmin: Limit label combobox behavior to VM dialogs

awels at redhat.com awels at redhat.com
Wed Jun 22 15:41:00 UTC 2016


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Limit label combobox behavior to VM dialogs
......................................................................


webadmin: Limit label combobox behavior to VM dialogs

This patch avoids a frontend ClassCastException by limiting the behavior
to new and existing VMs. It also removes the affinity label combobox
element from template and User Portal VM dialogs.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346960
Change-Id: I958c9ae240fc4f1b7f9e4e20e296ea484ba94e89
Signed-off-by: Phillip Bailey <phbailey at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java
4 files changed, 13 insertions(+), 5 deletions(-)

Approvals:
  Jakub Niedermertl: Looks good to me, but someone else must approve
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Phillip Bailey: Verified



-- 
To view, visit https://gerrit.ovirt.org/59412
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I958c9ae240fc4f1b7f9e4e20e296ea484ba94e89
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list