Change in ovirt-engine[ovirt-engine-4.0]: core: Marking VMs in stateless VM Pools as stateless

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: Marking VMs in stateless VM Pools as stateless
......................................................................


core: Marking VMs in stateless VM Pools as stateless

Previously, vm_static.is_stateless field was not used for pooled VMs.
This led to confusing results - when one uses REST API to get
information about a VM from a VM Pool, the REST API returns
<stateless>false</stateless>, while indeed all VMs in a stateless pool
are stateless. Webadmin UI also incorrectly displays "Is Stateless:
False" for these VM.

This patch adds setting is_stateless=true for all VMs created in a
stateless VM Pool and updates this field for all pooled VMs created
earlier.

Change-Id: I90da0c0877a471435e32837a4798e6f1a4e8205f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1318955
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/upgrade/04_00_0770_set_pool_vms_stateless.sql
10 files changed, 8 insertions(+), 16 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified



-- 
To view, visit https://gerrit.ovirt.org/59564
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90da0c0877a471435e32837a4798e6f1a4e8205f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>