Change in ovirt-engine[ovirt-engine-4.0]: core: fix PowerSavingWeight score calculation

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: fix PowerSavingWeight score calculation
......................................................................


core: fix PowerSavingWeight score calculation

EvenDistributionWeightPolicy unit calculated a weight score that was
comprised from CPU usage and memory consumption.
This calculation was wrong (which Power saving weight module relied on)
there was a need to separate the weight policy units to 2 units :
EvenDistributionCPUWeightPolicy and EvenDistributionMemoryWeightPolicy
which produced 2 new power saving units:
PowerSavingMemoryWeightPolicyUnit and PowerSavingMemoryCPUPolicyUnit
instead of PowerSavingWeightPolicyUnit.

CPU usage is calculated as before
(power saving unit takes the opposite score)
Memory score is calculated by
the range of 1 to the maximum available memory of a host in the cluster
and normalized to the score range.

NonWeightPolicy unit was removed and will replaced
with memory and CPU even distribution policies under
the default 'None' scheduling policy

Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b
Bug-Url: https://bugzilla.redhat.com/1260381
Signed-off-by: Yanir Quinn <yquinn at redhat.com>
Signed-off-by: yquinn <yquinn at redhat.com>
(cherry picked from commit 6037d18)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionMemoryWeightPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPoliciesTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java
10 files changed, 300 insertions(+), 82 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Yanir Quinn: Verified



-- 
To view, visit https://gerrit.ovirt.org/59674
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>