Change in ovirt-engine[master]: engine: Removing variable recycling in NetworkProviderValidator

tnisan at redhat.com tnisan at redhat.com
Thu Jun 30 12:52:17 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: engine: Removing variable recycling in NetworkProviderValidator
......................................................................


engine: Removing variable recycling in NetworkProviderValidator

Variable recycling is evil and must be eliminated. Splitting
result into pluginTypeValidation and authValidation.

Change-Id: If4a337a54fc91caca20e6c8524bb41f990fe5fcf
Bug-Url: https://bugzilla.redhat.com/1333728
Signed-off-by: mirecki <mmirecki at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidator.java
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Marcin Mirecki: Verified
  Martin Mucha: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59913
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4a337a54fc91caca20e6c8524bb41f990fe5fcf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list