Change in ovirt-engine-sdk-ruby[master]: Use mixin for methods common to structs and lists

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Mar 1 22:04:20 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Use mixin for methods common to structs and lists
......................................................................


Use mixin for methods common to structs and lists

Currently the "Struct" and "List" base classes contain duplicated code
to manage the "id" and "href" attributes and the "follow_link" method.
This patch introduces a new "Type" module that is used as a mixin to
contain that code and avoid the duplication.

Change-Id: I0a5a095dfcae70fed878eaf3d95ce331e68625c2
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M sdk/lib/ovirt/sdk/v4.rb
D sdk/lib/ovirt/sdk/v4/list.rb
R sdk/lib/ovirt/sdk/v4/type.rb
3 files changed, 19 insertions(+), 107 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5a095dfcae70fed878eaf3d95ce331e68625c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list