Change in ovirt-engine[master]: core: Extract redundant equals() implementation in PendingRe...

tnisan at redhat.com tnisan at redhat.com
Thu Mar 3 10:02:21 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Extract redundant equals() implementation in PendingResource subs
......................................................................


core: Extract redundant equals() implementation in PendingResource subs

Since all subclasses of PendingResource implement equals() in the same way
it's been extracted to an external class to avoid code duplication

Change-Id: I1372ad145a356bdc181ba4f63987e116c6f8995b
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingCpuCores.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingMemory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingVM.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VmSpecificPendingResourceEqualizer.java
4 files changed, 33 insertions(+), 42 deletions(-)

Approvals:
  Tal Nisan: Verified
  Martin Sivák: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54201
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1372ad145a356bdc181ba4f63987e116c6f8995b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list