Change in ovirt-engine[master]: core: extract vm jobs related code from vm-analyzer

[ahadas at redhat.com]

Arik Hadas has submitted this change and it was merged.

Change subject: core: extract vm jobs related code from vm-analyzer
......................................................................


core: extract vm jobs related code from vm-analyzer

VmAnalyzer should (ideally) take a VM that was reported by VDSM,
compare it to the previous information we have for that VM and
analyze the difference. However, the analyzer currently does
more than that and therefore is not easy to maintain.

This patch extracts the VM jobs handling from VmAnalyzer to a
new class called VmJobsMonitoring. The benefits are:
1. Less not-that-related code in VmAnalyzer and one less DAO
to pass to it.

2. We get to the point where the dynamic VM data is persisted
into the database faster as we push the queries that are done
in order to process the reported VM jobs to be after the VM
dynamic data is persisted to the database.

3. The processing of VM jobs is done by another module which
is a singleton and therefore it prepares the ground for
events-based updates of command callbacks and for possible
optimizations of the inefficient queries from the database
that are done in statistics monitoring cycles.

Change-Id: Ic244bfc0ca2aef014b09aaa2fcf4a1d7f1e9d166
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java
5 files changed, 108 insertions(+), 85 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Maor Lipchuk: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53587
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic244bfc0ca2aef014b09aaa2fcf4a1d7f1e9d166
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>