Change in ovirt-engine[master]: engine: Fix potential NPE in MoveOrCopyTemplate

mlipchuk at redhat.com mlipchuk at redhat.com
Mon Mar 7 16:55:02 UTC 2016


Maor Lipchuk has submitted this change and it was merged.

Change subject: engine: Fix potential NPE in MoveOrCopyTemplate
......................................................................


engine: Fix potential NPE in MoveOrCopyTemplate

In order to prevent a potential NPE in MoveOrCopyTemplateCommand,
the function getImages returns emptyList instead of null.

This patch addresses Coverity CID 1348251

Change-Id: Iacb2e411ce4b8d6474935058d08f034fa590d6d9
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Looks good to me, approved
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54210
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iacb2e411ce4b8d6474935058d08f034fa590d6d9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list