Change in ovirt-engine[master]: core: Remove wrong code in AddVmAndAttachToPoolCommand

tnisan at redhat.com tnisan at redhat.com
Thu Mar 17 12:15:00 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove wrong code in AddVmAndAttachToPoolCommand
......................................................................


core: Remove wrong code in AddVmAndAttachToPoolCommand

AddVmAndAttachToPoolCommand is adding a VM to an exisiting pool, the VM
added to the pool is based on the same non blank template as the rest of
the pool so the logic of creating a VM based on a blank template is wrong
and thus can be removed

Change-Id: I48f484f44e812063aabbb8bb7f7008616e4ffa5c
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
1 file changed, 16 insertions(+), 25 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54812
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I48f484f44e812063aabbb8bb7f7008616e4ffa5c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list