Change in ovirt-engine[master]: core: Remove InitStorageSparseSizeInGB ConfigValue

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove InitStorageSparseSizeInGB ConfigValue
......................................................................


core: Remove InitStorageSparseSizeInGB ConfigValue

The InitStorageSparseSizeInGB ConfigValue is pointless, as the size
property of the disk already takes this into account. It has been
removed from production code throughout the codebase (although,
surprisingly, it was not removed from the tests), and only appears
mistakenly in the quote calculation of creating a new pool, where it has
no effect anyway, as its value is 1 and it's used in multiplication.

This patch finishes the job and removes all trace of this redundant
config value

Change-Id: I4358a78a88898fc93b095becc883dec5d066246e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A packaging/dbscripts/upgrade/04_00_0310_delete_init_storage_sparse_size_in_gb.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
6 files changed, 2 insertions(+), 14 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Eli Mesika: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4358a78a88898fc93b095becc883dec5d066246e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>