Change in ovirt-engine[master]: core: Avoid errors when applying NEXT_RUN snapshot

ahadas at redhat.com ahadas at redhat.com
Sun Mar 20 17:26:27 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: Avoid errors when applying NEXT_RUN snapshot
......................................................................


core: Avoid errors when applying NEXT_RUN snapshot

* Ignore changes in clusterCompatibilityVersionOrigin. It is not stored
  in OVF, so will never be changed when a snapshot is applied.

* Do not check CPU Profile changing permissons, if cpuProfileId is not
  changed. Current user is null in ProcessDownVmCommand, so this
  permission check will always fail. But cpuProfileId is not stored in
  OVF, so will never be changed when a snapshot is applied and there is
  no need to check permissions.

Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1313369
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list