Change in ovirt-engine[master]: build: animal-sniffer in compile time

amureini at redhat.com amureini at redhat.com
Wed Mar 23 18:39:52 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: build: animal-sniffer in compile time
......................................................................


build: animal-sniffer in compile time

animal-sniffer is an important check that prevents future breakages in
GWT.

As it's no longer run in CI, and as it takes a negligible time to run
this patch makes sure it will be run as part of the build, and is
governed by a property (like, e.g., checkstyle, which is much more
expensive)

Change-Id: I678cf246a446f2146de93b5f96a35ec0091234fc
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M build-tools-root/ovirt-findbugs-filters/pom.xml
M frontend/webadmin/modules/pom.xml
M pom.xml
7 files changed, 44 insertions(+), 98 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I678cf246a446f2146de93b5f96a35ec0091234fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list