Change in ovirt-engine[master]: core: remove redundant null checks in vm-analyzer

[ahadas at redhat.com]

Arik Hadas has submitted this change and it was merged.

Change subject: core: remove redundant null checks in vm-analyzer
......................................................................


core: remove redundant null checks in vm-analyzer

In processDownVms when detecting that the dbVm is null we used to check
if the dynamic data of the VM exists in the database. This is not needed
anymore since it must exist - if dbVm is null and the dynamic data is
not in the DB it means that it is an external VM and when detecting an
external VM we immediately insert its dynamic part to the DB and don't
continue to the processDownVms method in the same iteration.

Same goes to the updateRepository method.

Change-Id: I7e23388c12c0724eb4c852f1e6f142f5ba72fd3f
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55305
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e23388c12c0724eb4c852f1e6f142f5ba72fd3f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>