Change in ovirt-engine-sdk[master]: Use type safe enums

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Mar 30 09:51:07 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Use type safe enums
......................................................................


Use type safe enums

Currently the SDK implements enum values as constants with string
values. This means that it isn't possible to check their type. To
improve that, this patch changes the SDK to use type safe enums instead
of strings.

Change-Id: I581ff287a37682ae2955808bc71fa25a38432517
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M automation/build-artifacts.packages.el7
M automation/build-artifacts.packages.fc23
M automation/check-patch.packages.el7
M automation/check-patch.packages.fc23
M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
M packaging/spec.el7.in
M packaging/spec.fc23.in
M pom.xml
M sdk/examples/add_host.py
M sdk/examples/add_nfs_data_storage_domain.py
M sdk/examples/add_nfs_iso_storage_domain.py
M sdk/examples/add_vm_disk.py
M sdk/examples/attach_nfs_data_storage_domain.py
M sdk/examples/attach_nfs_iso_storage_domain.py
M sdk/examples/remove_host.py
M sdk/examples/start_vm.py
M sdk/examples/stop_vm.py
M sdk/setup.py
20 files changed, 88 insertions(+), 34 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55405
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I581ff287a37682ae2955808bc71fa25a38432517
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list