Change in ovirt-engine[master]: core: Inline MoveOrCopyTemplateCommand#getMoveOrCopyImageOpe...

amureini at redhat.com amureini at redhat.com
Wed Mar 30 17:23:19 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Inline MoveOrCopyTemplateCommand#getMoveOrCopyImageOperation()
......................................................................


core: Inline MoveOrCopyTemplateCommand#getMoveOrCopyImageOperation()

As getMoveOrCopyImageOperation() just returns the constant
ImageOperation.Copy, there's no point of having it as a method.

This patch inlines it in order to improve the code's readability.

Change-Id: I8bd3ab3648a93c58677d8214a9e882748b4895e9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java
4 files changed, 9 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bd3ab3648a93c58677d8214a9e882748b4895e9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list