Change in ovirt-engine[master]: webadmin: AsyncDataProvider#isCommandCompatible default

amureini at redhat.com amureini at redhat.com
Thu Mar 31 16:08:12 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: AsyncDataProvider#isCommandCompatible default
......................................................................


webadmin: AsyncDataProvider#isCommandCompatible default

If a command is not present in the action version map, it's assumed to
be supported for any DC/cluster level, and thus shouldn't even be
checked by this method.

However, as an infrastructure, this method cannot assume it will be used
correctly, and needs to return the proper default (true) if used
improperly in this way.

Change-Id: Ifdf1d75f59f2eec353c4a7f879994ca2fddba42e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, but someone else must approve
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdf1d75f59f2eec353c4a7f879994ca2fddba42e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list