Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: correctly evaluate glusterfs SD canonical path

sbonazzo at redhat.com sbonazzo at redhat.com
Mon May 2 11:49:04 UTC 2016


Sandro Bonazzola has submitted this change and it was merged.

Change subject: storage: correctly evaluate glusterfs SD canonical path
......................................................................


storage: correctly evaluate glusterfs SD canonical path

In the past we let the user specify a path for file based
(NFS or gluster) storage domains which includes a trailing '/'.
This caused other issues (double mount point when the engine
import it) and so we had a patch to evaluate the canonical path
and eventually fix the mount point in the configuration file
before trying again to connect it. Due to a bug in the evaluation
of the canonical path for gluster volumes, it was looping forever
on gluster deployed systems.
Improoving the the logging to make it more evident.

Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb
Bug-Url: https://bugzilla.redhat.com/1327516
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/env/path.py
M ovirt_hosted_engine_ha/lib/storage_server.py
3 files changed, 34 insertions(+), 17 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list