Change in ovirt-engine[master]: webadmin,userportal: Code cleanup

vszocs at redhat.com vszocs at redhat.com
Mon May 2 19:17:52 UTC 2016


Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: Code cleanup
......................................................................


webadmin,userportal: Code cleanup

1. removed unused InternalConfiguration class
   along with its GIN binding

2. added ClientAgentType.isFirefox method

3. updated code to use ClientAgentType.isIE and
   ClientAgentType.isFirefox methods instead of
   hard-coded string comparison

Change-Id: Ie20290cefa9e7f18399b6a5db1a4882a540229f2
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ClientAgentType.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java
5 files changed, 8 insertions(+), 106 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/56939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie20290cefa9e7f18399b6a5db1a4882a540229f2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list