Change in ovirt-engine[master]: core: Unify addVmImages method in AddVm and AddVmFromTemplat...

tnisan at redhat.com tnisan at redhat.com
Fri May 6 10:26:48 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Unify addVmImages method in AddVm and AddVmFromTemplate commands
......................................................................


core: Unify addVmImages method in AddVm and AddVmFromTemplate commands

Both commands are using the same boilerplate code with little difference
only in the action type and way of locking the VM, both methods were
unified to one method to avoid maintaining the same code in two places

Change-Id: I29a1cc22dbca57c212a68bbd7fe52c0154cfa6fa
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
2 files changed, 26 insertions(+), 37 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve
  Ala Hino: Looks good to me, but someone else must approve
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29a1cc22dbca57c212a68bbd7fe52c0154cfa6fa
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list