Change in ovirt-hosted-engine-setup[master]: network: skip NetworkManager check/disable via answerfile

[stirabos at redhat.com]

Simone Tiraboschi has submitted this change and it was merged.

Change subject: network: skip NetworkManager check/disable via answerfile
......................................................................


network: skip NetworkManager check/disable via answerfile

Adding the capability to skip NM check and disabling by
host-deploy via answerfile (dafault enforcing).
In the normal flow, host-deploy will disable NetworkManager if active.
When host-deploy runs, the management bridge has already been created
and the engine VM is already running so disabling NetworkManager on
the fly can be risky for the engine VM networking.
To avoid that, ovirt-hosted-engine-setup will check NetworkManager
status and eventually ask the user to stop:
this behavior wasn't configurable.
On the other side Next Generation Node is based on Cockpit, which
requires NetworkManager to report the network status.
Next Generation Node comes with NetworkManager-config-server
so NetworkManager there should be passive enough.
With this patch we make its check optionally skippable via answerfile.

Change-Id: Iaec165cfb8bf93a3a17af20b23ce97ec2ad3223d
Bug-Url: https://bugzilla.redhat.com/1337050
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-setup/engine/add_host.py
M src/plugins/gr-he-setup/network/bridge.py
3 files changed, 21 insertions(+), 3 deletions(-)

Approvals:
  Simone Tiraboschi: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56146
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaec165cfb8bf93a3a17af20b23ce97ec2ad3223d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>