Change in ovirt-engine[master]: core: Kernel cmdline - data layer

[tjelinek at redhat.com]

Tomas Jelinek has submitted this change and it was merged.

Change subject: core: Kernel cmdline - data layer
......................................................................


core: Kernel cmdline - data layer

This feature allows to customize kernel commandline (bootloader
configuration) of hosts.

The configuration is stored in vds_static table in columns:
kernel_cmdline and last_stored_kernel_cmdline. 'kernel_cmdline' column
is JSON structured and  holds values of checkboxes for UI and
generated line to be send to hosts. The line is never parsed to
checkboxes again. 'last_stored_kernel_cmdline' column contains last
successfully stored line in host. Line from 'kernel_cmdline' column will
be copied to last_stored_kernel_cmdline after successful host deploy.

VdsStaticDao#update method and underlying stored procedure don't
update 'last_stored_kernel_cmdline' column to prevent accidental change.
There is separate VdsStaticDao#updateLastStoredKernelCmdline that
called that will only be called from host deploy.

Host deploy procedure will send both current and last stored line to the
host because the tool manipulating bootloader configuration - grubby -
can't actually read the configuration, only write. Thus old
configuration is necessary to know what to remove before applying new
configuration.

Bug-Url: https://bugzilla.redhat.com/1301104
Change-Id: I93c1d299fa9c86c2bf4dc958904f61aaccf38ec4
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_00_0680_vds_add_kernel_args_columns.sql
M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
M packaging/dbscripts/vds_sp.sql
12 files changed, 328 insertions(+), 14 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I93c1d299fa9c86c2bf4dc958904f61aaccf38ec4
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>