Change in ovirt-engine[master]: core: Change singletonList to new Array for StorageCommandBase.

mlipchuk at redhat.com mlipchuk at redhat.com
Wed May 18 11:25:45 UTC 2016


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Change singletonList to new Array for StorageCommandBase.
......................................................................


core: Change singletonList to new Array for StorageCommandBase.

Each command inherited from StorageDomainCommandBase,
which does not implement the procedure getPermissionCheckSubjects,
will risk an exception of UnsupportedOperationException
once a new permission will be added to it.

An example of a failure can be found when using enabling
quota in a Data Center.

Hence, changing permissionCheckSubjects singleton collection
to use a new array list instead.

Change-Id: Ida67a4409509652d5eeb1a953c3537051e4e61bb
Signed-off-by: Maor Lipchuk <maorlipchuk at gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57584
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida67a4409509652d5eeb1a953c3537051e4e61bb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list