Change in ovirt-engine[master]: engine: fix coverity warnings

alkaplan at redhat.com alkaplan at redhat.com
Thu May 19 07:12:09 UTC 2016


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: fix coverity warnings
......................................................................


engine: fix coverity warnings

The patch fixes the following Coverity warnings:
* CID 1355030 - Dereference of an explicit null value
* CID 1355031 - Dereference of an explicit null value

Also it adds test coverage for getIpv[46]AddressOfNetwork methods.

Change-Id: I2fa38b889cb97b41a9e34e646c39903273a1128e
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkConfiguratorTest.java
1 file changed, 49 insertions(+), 17 deletions(-)

Approvals:
  Martin Mucha: Looks good to me, but someone else must approve
  Alona Kaplan: Looks good to me, approved; Passed CI tests
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/57112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fa38b889cb97b41a9e34e646c39903273a1128e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list