Change in ovirt-engine[ovirt-engine-3.6]: core: Fix permissions for profiles created for new domain

[piotr.kliczewski at gmail.com]

Piotr Kliczewski has submitted this change and it was merged.

Change subject: core: Fix permissions for profiles created for new domain
......................................................................


core: Fix permissions for profiles created for new domain

The AddDiskProfileCommand takes care of the permissions for newly
added disk profiles and gives the users in Everyone group the
DiskProfileUser role.
AddStorageDomain command added the created disk profile directly
to the DB without calling the command and so this role was not
assigned.
The fix was to call AddDiskProfileCommand directly from
AddStorageDomain and also from AddStorageDomainToPoolCommand which
creates a disk profile in case one doesn't exist for the storage domain.
A new constructor was added to AddSTorageDomainCommand class, this 
constructor existed on the master branch and was required in order to 
enable calling that command internally. 
Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459
Bug-Url: https://bugzilla.redhat.com/1209505
Signed-off-by: Jenny Tokar <jtokar at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java
7 files changed, 47 insertions(+), 30 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Maor Lipchuk: Looks good to me, but someone else must approve
  Jenny Tokar: Verified



-- 
To view, visit https://gerrit.ovirt.org/57526
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>